Proper handling of several code sections in Codeview debug information #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Codeview implementation assumes there is only one actual code section and all line number information is pulled there. With support of comdat that assumption becomes incorrect, so proper generation of line number information table per code section is required.
Also solved an issue with incorrect relocation for symbol with the same name as some section.
New code assumes that
coff_nsectsdoesn't change during generation of debug information.After removal of
cv8_outputit seems there is now unused code/data inoutcoff.c/pecoff.hthat is not removed in this pull request. I can add the cleanup if they are indeed no longer needed.