adjust script path names in the Dockerfile so that no additional options are required to build the docker image #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the CI is using custom options to build the docker image. Perhaps these options should be documented in the README file (or the script path names should be adjusted so that additional options are not required). |
ustorbeck
force-pushed
the
docker_path_names
branch
from
10241f0 to
ee927b7
Compare
No additional options are required to build the docker image.
ustorbeck
force-pushed
the
docker_path_names
branch
from
ee927b7 to
f62fa00
Compare
|
I've updated the PR to also adjust the CI command so that everything fits together again. |
ustorbeck
changed the title
scuzzilla
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the docker image fails for me (on rocky linux 8.9). This PR adjusts the script path names in the docker file so that the image build succeeds.