Feature/imgproxy builder override #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For readability I created a new pull request, I hope this is ok.
Related Pull Request: #11
As you mentioned in the related pull request I created an interface for the ImgproxyBuilder class allowing to override it by using the Objects.yaml. Additionally I added the ThumbnailConfiguration object to the ImgproxyBuilder and a addProcessingOption allowing to add processing options inside the generateUrl method using this configuration object.
Example how to override the ImgproxyBuilder class:
Classes/ImgproxyBuilder.php:
Configuration/Objects.yaml:
Please let me know what you think about this, if this meets your expectations I would also add the example to the README file.
Regards,
Cyrill