Napalm and Netmiko optional arguments support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbox_onboarding/migrations/0003_onboardingtask_change_logging_model.py
Outdated
Show resolved
Hide resolved
carbonarok
force-pushed
the
develop-2.0-napalm-support
branch
from
84c810a to
bab41d0
Compare
|
@carbonarok Can you please appear as a single change - 1 commit, 1 file modified within a PR. Please make sure the build is passing |
mzbroch
force-pushed
the
develop-2.0-napalm-support
branch
from
bab41d0 to
4d1668c
Compare
carbonarok
force-pushed
the
develop-2.0-napalm-support
branch
2 times, most recently
from
5665747 to
e209b17
Compare
mzbroch
changed the title
carbonarok
force-pushed
the
develop-2.0-napalm-support
branch
3 times, most recently
from
b3361d7 to
d375845
Compare
mzbroch
force-pushed
the
develop-2.0-napalm-support
branch
from
d375845 to
37d3c73
Compare
mzbroch
approved these changes
Nov 9, 2020
|
Looks reasonable to me; would be nice to have some unit tests though. |
mzbroch
force-pushed
the
develop-2.0-napalm-support
branch
from
886af99 to
365ec0f
Compare
mzbroch
force-pushed
the
develop-2.0-napalm-support
branch
2 times, most recently
from
832ea1c to
c91911c
Compare
mzbroch
force-pushed
the
develop-2.0-napalm-support
branch
from
c91911c to
b32cbf1
Compare
mzbroch
force-pushed
the
develop-2.0-napalm-support
branch
from
b32cbf1 to
b184a9f
Compare
This was referenced Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR extends the onboarding plugin with possibility of specifying optional arguments for Netmiko And NAPALM connections.
The Netmiko connection is being used to discover the netmiko device type. Napalm connection is being used to get facts from a device.
Optional arguments are loaded in the following manner :
settings.NAPALM_USERNAME and PASSWORDsettings.NAPALM_ARGSoptional_args: # 1otm.optional_args, # 2settings.NAPALM_ARGS,Closes issues #80, #102, #103