Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Platform Mapping in Settings #55

Merged
merged 14 commits into from
Jul 9, 2020
Merged

Support Platform Mapping in Settings #55

merged 14 commits into from
Jul 9, 2020

Conversation

jvanderaa
Copy link
Contributor

@jvanderaa jvanderaa commented Jun 26, 2020 •
edited
Loading

  • Adds .bandit.yml config file
  • Adds local directory to the docker volume for bandit config
  • Adds method to check device platform assignment based on mapping
  • Creates test for method
  • Updates Bandit to use config file
  • Renames test_onboard.py -> test_netbox_keeper.py

Fixes #49

@jvanderaa jvanderaa requested a review from dgarros June 26, 2020 18:53
dgarros
dgarros reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jvanderaa
Looks like a good start but unless I'm missing something I don't think this PR is complete :)
I don't see the code that is using the new function during the onboarding process

glennmatthews
glennmatthews reviewed Jun 29, 2020
View reviewed changes
glennmatthews
glennmatthews reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document this new setting in README.md and add its default value {} to netbox_onboarding/__init__.py.

@jvanderaa jvanderaa requested a review from glennmatthews July 8, 2020 20:47
glennmatthews
glennmatthews reviewed Jul 8, 2020
View reviewed changes
dgarros
dgarros approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@dgarros dgarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jvanderaa

@dgarros
Copy link
Contributor

dgarros commented Jul 8, 2020

@glennmatthews are you good to merge ?

@glennmatthews
Copy link
Contributor

Rebase/merge appears incorrect to me - we have merge conflicts and your diffs are showing check_ip as new code, which it shouldn't be in this PR.

@jvanderaa jvanderaa force-pushed the jv_platform_mappings branch from 234ad32 to 7a143a1 Compare July 9, 2020 16:04
@glennmatthews glennmatthews merged commit 2704750 into networktocode:master Jul 9, 2020
@glennmatthews glennmatthews mentioned this pull request Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgarros dgarros dgarros approved these changes

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass netbox plugin settings for default mappings
3 participants
@jvanderaa @dgarros @glennmatthews