Q2 and Q6 protocols implementation #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Viktor Drobot <[email protected]>
Signed-off-by: Viktor Drobot <[email protected]>
…2798] Signed-off-by: Jim Klimov <[email protected]>
…pstools#2798] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
feature
Qx protocol driver
Signed-off-by: Jim Klimov <[email protected]>
|
Great thanks! I've updated some files "cosmetically", but the PR looks reasonable and solid otherwise. Hope CI agrees soon-ish :) |
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
|
I'll also try some extra tests tomorrow on our Innovas |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deeply sorry for a long delay, but finally, here is basic implementation of Q2 and Q6 protocol variants. Because of that I've also narrowed down
INNOVART31protocol to support just this specific model.If I would be able to get Innova RT 3/3 model I'll make special variant for that too (just want to be on safe side and test things before public rollout), but as for now new Q2/Q6 proto should suffice for these models