Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BP] Allow to parametrize WebDriverwait #224

Closed
1 task
Tracked by #304
netzulo opened this issue Feb 14, 2019 · 0 comments · May be fixed by #304
Closed
1 task
Tracked by #304

[BP] Allow to parametrize WebDriverwait #224

netzulo opened this issue Feb 14, 2019 · 0 comments · May be fixed by #304
Assignees
@netzulo
Labels
Awaiting-PR Work In Progress at some pull request Best Practice Not functionality problem, but refactor need it

Comments

@netzulo
Copy link
Owner

netzulo commented Feb 14, 2019 •
edited
Loading

Obtained Behaviour

Can't redefine WebDriverWait timeout on each call

Expected Behaviour

Can redefine WebDriverWait timeout on each call

Tests

  • Exec some webdriverwait method call to allow check default timeout (at instance) and parameter value timeout (at method call)

Notes

qacode/qacode/core/bots/bot_base.py

Line 131 in 7dc7090

self.curr_driver_wait = WebDriverWait(self.curr_driver, 10)

Maybe if move others drivers instantitation from BotBase to NavBase allow to handle times from NavBase directly
@netzulo netzulo added the Best Practice Not functionality problem, but refactor need it label Feb 14, 2019
@netzulo netzulo self-assigned this Feb 14, 2019
@netzulo netzulo added the Awaiting-PR Work In Progress at some pull request label Feb 9, 2020
@netzulo netzulo linked a pull request Feb 9, 2020 that will close this issue
WIP, refactoring all library #304
Open
7 tasks
@netzulo netzulo mentioned this issue Mar 15, 2020
Open
7 tasks
@netzulo netzulo closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netzulo netzulo

Labels
Awaiting-PR Work In Progress at some pull request Best Practice Not functionality problem, but refactor need it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP, refactoring all library netzulo/qacode
1 participant
@netzulo