Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP, refactoring all library #304

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

WIP, refactoring all library #304

wants to merge 49 commits into from

Conversation

netzulo
Copy link
Owner

@netzulo netzulo commented Jan 29, 2020

@netzulo netzulo added Feature New functionality proposal Best Practice Not functionality problem, but refactor need it Testcase Documentation Related to documentation CI Related to some Continuous Integration labels Jan 29, 2020
@netzulo netzulo self-assigned this Jan 29, 2020
@netzulo netzulo linked an issue Apr 6, 2020 that may be closed by this pull request
@codeclimate
Copy link

codeclimate bot commented May 25, 2021

Code Climate has analyzed commit fa460d6 and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3
Clarity 1

View more on Code Climate.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7698 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7698 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Owner Author

@netzulo netzulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok at this point

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7746 lines exceeds the maximum allowed for the inline comments feature.

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 7371 lines exceeds the maximum allowed for the inline comments feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Best Practice Not functionality problem, but refactor need it Bug Problem in software code CI Related to some Continuous Integration dependencies Pull requests that update a dependency file Documentation Related to documentation Feature New functionality proposal Testcase
Projects
None yet
1 participant