Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qacode] new ControlTable class, #248 #264

Merged
merged 7 commits into from
Apr 19, 2019
Merged

[qacode] new ControlTable class, #248 #264

merged 7 commits into from
Apr 19, 2019

Conversation

netzulo
Copy link
Owner

@netzulo netzulo commented Apr 14, 2019 •
edited
Loading

Issues related

  • new class ControlTable
  • inherit of ControlForm
  • validate tag table tag at instantiation

@netzulo
[qacode] starting issue #248 , WIP control_table
bc2a2ea 
+ new class ControlTable
+ inherit of ControlForm
+ validate tag table tag at instantiation
@netzulo netzulo added Feature New functionality proposal Best Practice Not functionality problem, but refactor need it Testcase Documentation Related to documentation labels Apr 14, 2019
@netzulo netzulo self-assigned this Apr 14, 2019
@netzulo
[qacode] more WIP changes for control_table #248
55398a4 
+ added new property rows allow to acces to tr tags as rows
    at list of ControlBase array + tests
@codeclimate
Copy link

codeclimate bot commented Apr 14, 2019 •
edited
Loading

Code Climate has analyzed commit 4b5d6ba and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 92.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 86.8% (0.5% change).

View more on Code Climate.

@netzulo
[qacode] more fixes for issue #248
1bea511 
+ some exception messages moved to logger_messages
+ controls can handle None strict_tags values
+ ctl_dd refactor , added internal check for some methods
+ fix last commit refactor for ctl_form, bad call
+ ctl_tb added html5 structure data tags load
+ added more tests for ctl_tb
@netzulo netzulo changed the title [qacode] starting issue #248 , WIP control_table [qacode] new ControlTable class, #248 Apr 19, 2019
@netzulo netzulo merged commit 7da1cec into master Apr 19, 2019
@netzulo netzulo deleted the issue248 branch April 19, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate CodeClimate CodeClimate left review comments

Assignees

@netzulo netzulo

Labels
Best Practice Not functionality problem, but refactor need it Documentation Related to documentation Feature New functionality proposal Testcase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@netzulo