Stop stage sweeps on server congestion#66
Open
tlrmchlsmth wants to merge 2 commits into
Open
Conversation
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com>
Signed-off-by: Tyler Michael Smith <tlrmchlsmth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
until_congested()Starlark helper for finite stage sweepsHow congestion is determined
Checks run after each measured stage. Threshold comparisons are inclusive. The first 20% and final 5% of a stage are excluded as ramp/boundary time; short stages use their full duration.
waiting_requests_p50andttft_p99are both reached; these may come from different PD roles because they represent end-to-end latencykv_cache_usageandpreemptionsare both reached on the same roleMissing series evaluate as zero. Query failures are logged and fail open. The congested stage remains in the results; only later stages are skipped.
Starlark configuration
waiting_requests_p50andttft_p99are required and deployment-specific.kv_cache_usagedefaults to0.95(fraction) andpreemptionsdefaults to1per stage.Balanced example
Latency-sensitive example
Throughput-oriented example
Run with:
Testing
go test ./... -count=1