Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Diagnosis Levels with correct API response #49 #57

Merged
merged 18 commits into from
Aug 15, 2024

Conversation

tvilight4
Copy link
Contributor

@tvilight4 tvilight4 commented Aug 15, 2024

Changes proposed in this pull request:

  • Addition of levels of the diagnosis.
  • Adding the code to the API code so that the levels are reflected in the API output.

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link
Contributor

@barbarastrasser barbarastrasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code runs and does what it should do :) I have left some minor comments. The important are the ones about the test and the file location - this would be good to address before merging. Everything else is just about print statements - we can also leave them in if you prefer :)

tests/test_processing_api.py Show resolved Hide resolved
app/categorization/llm_helper.py Outdated Show resolved Hide resolved
app/parsing/json_parsing.py Outdated Show resolved Hide resolved
app/parsing/json_parsing.py Outdated Show resolved Hide resolved
app/processing.py Outdated Show resolved Hide resolved
app/categorization/llm_categorization.py Outdated Show resolved Hide resolved
@tvilight4 tvilight4 merged commit 825ffe8 into main Aug 15, 2024
2 checks passed
@tvilight4 tvilight4 deleted the 49_Levels_of_Diagnosis branch August 15, 2024 09:48
@tvilight4 tvilight4 restored the 49_Levels_of_Diagnosis branch August 15, 2024 09:49
@tvilight4 tvilight4 self-assigned this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify levels of diagnosis
2 participants