You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We do not yet support uploading an already annotated data dictionary (see #601). However, if a user regardless uploads an already annotated data dictionary the app will happily take it. This leads to some very confusing states:
if I provide a completely annotated data dictionary 🤷 then the visual state of the app will tell me nothing is annotated yet, but my download will include all my existing annotations
if I provide an invalid data dictionary then again, the UI looks empty, but when I come to the download page and my data dictionary is validated, the validation will fail. Unless I guess what's going on, I cannot fix that
So in short: the state of the data dictionary in the app and the visual UI do not correspond to each other, and that's quite bad.
We have two options:
Put a big red warning on the first page that says: you cannot load a data dictionary with neurobagel annotations
I lean towards 2 because we will likely refactor this soon
TODO:
when existing data dictionary is loaded, strip away / rest the "Annotations" part
big warning on Home page near the "data dictionary" upload button to say "cannot reuse annotations"
test that existing annotations do not make it through the tool, e.g. no unintentional annotations
The text was updated successfully, but these errors were encountered:
surchs
added
bug:ux
Unexpected and unintended behavior that is detrimental to the user experience.
type:bug
Defects in shipped code and fixes for those defects
flag:schedule
Flag issue that should go on the roadmap or backlog.
and removed
flag:schedule
Flag issue that should go on the roadmap or backlog.
labels
Jan 16, 2024
We do not yet support uploading an already annotated data dictionary (see #601). However, if a user regardless uploads an already annotated data dictionary the app will happily take it. This leads to some very confusing states:
So in short: the state of the data dictionary in the app and the visual UI do not correspond to each other, and that's quite bad.
We have two options:
I lean towards 2 because we will likely refactor this soon
TODO:
The text was updated successfully, but these errors were encountered: