Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove existing annotations from data dictionaries #715

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Apr 10, 2024

Changes proposed in this pull request:

  • expandable warning button on home page to say "can't reuse"
  • strip "Annotations" keys from data dictionary after loading in store
  • note: there is no test for this because the processDataDictionary store method never had a test written ...

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

This step does not have a test because the corresponding
store method never received one ...
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit 1f22c2e
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/661d64c49cf47100084c84dc
😎 Deploy Preview https://deploy-preview-715--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmanaem rmanaem self-requested a review April 11, 2024 14:21
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo fix and then 🧑‍🍳

pages/home.vue Outdated Show resolved Hide resolved
@surchs surchs merged commit e335b03 into main Apr 15, 2024
9 checks passed
@surchs surchs deleted the issue677 branch April 15, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a user provides an annotated dictionary, the app ignores it but keeps the annotations
2 participants