Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Modified the deployment process to trigger on release #802

Merged
merged 3 commits into from
Oct 29, 2024
Merged

[MNT] Modified the deployment process to trigger on release #802

merged 3 commits into from
Oct 29, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 27, 2024 •
edited by surchs
Loading

Changes proposed in this pull request:

  • Updated deployment cd workflow to trigger on release instead of push to main
  • Updated README.md with the mention of nightly deployment of the app

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@netlify Netlify
Copy link

netlify bot commented Oct 27, 2024 •
edited
Loading

✅ Deploy Preview for neurobagel-annotator ready!

Name Link
🔨 Latest commit d00f833
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-annotator/deploys/6720bdaf7a9d470008b40fd6
😎 Deploy Preview https://deploy-preview-802--neurobagel-annotator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

surchs
surchs approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@rmanaem rmanaem merged commit b20bace into main Oct 29, 2024
9 checks passed
@rmanaem rmanaem deleted the maint-790 branch October 29, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move to deploy-on-release
2 participants
@rmanaem @surchs