Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Return list instead of only first term for subject-level assessment #133

Merged
merged 1 commit into from
Jun 22, 2023
Merged

[FIX] Return list instead of only first term for subject-level assessment #133

merged 1 commit into from
Jun 22, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jun 21, 2023 •
edited by rmanaem
Loading

Closes #132

Checklist

  • PR has an interpretable title with a prefix ([ENH], [BUG], [DOC], [INFRA], [MAINT])
  • PR links to Github issue with mention Closes #XXXX
  • Tests pass
  • Code is properly formatted

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai requested a review from rmanaem June 21, 2023 23:04
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5339754299

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 5336640085: 0.0%
Covered Lines: 158
Relevant Lines: 158
💛 - Coveralls

rmanaem
rmanaem approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit c6d0742 into main Jun 22, 2023
2 checks passed
@alyssadai alyssadai deleted the fix-132/return-assessment-list branch June 22, 2023 14:43
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subjects can have multiple assessments but API only returns first one
3 participants
@alyssadai @coveralls @rmanaem