Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Remove query tool config #238

Merged
merged 1 commit into from
Dec 6, 2023
Merged

[FIX] Remove query tool config #238

merged 1 commit into from
Dec 6, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Dec 6, 2023

Changes proposed in this pull request:

  • updated the template
  • rewrote README section to point to docs
  • removed query tool from docker compose stack

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7116250448

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.771%
Totals Coverage Status
Change from base Build 7065800151: 0.0%
Covered Lines: 873
Relevant Lines: 875
💛 - Coveralls

@rmanaem rmanaem self-requested a review December 6, 2023 19:10
rmanaem
rmanaem approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs surchs merged commit df4353a into main Dec 6, 2023
5 checks passed
@surchs surchs deleted the issue226 branch December 6, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmanaem rmanaem rmanaem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove query tool specific configs from API-graph environment variable table
3 participants
@surchs @coveralls @rmanaem