Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Support queries of session-level phenotypic attributes #264

Merged
merged 13 commits into from
Jan 24, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jan 22, 2024

See also:

Changes proposed in this pull request:

  • Default timeout for POST request to graph extended
  • min_num_sessions query parameter split up for phenotypic and imaging sessions
  • New data model created for a specific session result in the API response
    • Includes new key "session_type" to differentiate phenotypic from imaging data
  • Removed unnecessary manual ordering of variables returned from graph
  • SPARQL query template updated to query for session-level attributes and count matching phenotypic sessions based on session-level filters
  • Existing tests updated

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) label Jan 22, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jan 22, 2024

Pull Request Test Coverage Report for Build 7643480556

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 99.779%

Totals Coverage Status
Change from base Build 7580111020: 0.008%
Covered Lines: 901
Relevant Lines: 903

💛 - Coveralls

@surchs surchs self-requested a review January 22, 2024 21:28
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai, that's a pretty big PR. From reading through it all (most) makes a lot of sense to me and I added questions / suggestions where not. Take a look, but I think this is all good to go 🧑‍🍳

tests/test_query.py Show resolved Hide resolved
tests/test_query.py Outdated Show resolved Hide resolved
app/api/crud.py Show resolved Hide resolved
app/api/utility.py Outdated Show resolved Hide resolved
app/api/utility.py Show resolved Hide resolved
@alyssadai alyssadai merged commit 2c6a2be into main Jan 24, 2024
6 checks passed
@alyssadai alyssadai deleted the support-session-level-queries branch January 24, 2024 16:52
@alyssadai alyssadai changed the title Support queries of session-level phenotypic attributes [ENH] Support queries of session-level phenotypic attributes Mar 25, 2024
@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

🚀 PR was released in v0.2.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
3 participants