Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Address performance issues in SPARQL query #308

Merged
merged 7 commits into from
Apr 16, 2024
Merged

[FIX] Address performance issues in SPARQL query #308

merged 7 commits into from
Apr 16, 2024

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Apr 15, 2024

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

For improved readability
Removes need to traverse entire graph
Improves query performance by a lot
it served its purpose

This reverts commit ffc36ae.
@surchs surchs added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Apr 15, 2024
@coveralls
Copy link
Collaborator

coveralls commented Apr 15, 2024

Pull Request Test Coverage Report for Build 8693379517

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.788%

Totals Coverage Status
Change from base Build 8670779129: 0.0%
Covered Lines: 940
Relevant Lines: 942

💛 - Coveralls

also addressed flake8 complaints
@alyssadai
Copy link
Contributor

Please update the default query file as well, in docs/!

@alyssadai
Copy link
Contributor

https://github.com/neurobagel/api?tab=readme-ov-file#the-default-neurobagel-sparql-query

Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs surchs added the release Create a release when this PR is merged label Apr 16, 2024
@surchs surchs merged commit d276155 into main Apr 16, 2024
6 checks passed
@surchs surchs deleted the iss-307 branch April 16, 2024 20:19
@surchs
Copy link
Contributor Author

surchs commented Apr 16, 2024

🚀 PR was released in v0.2.1 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve inefficient SPARQL query template Typo in query template
3 participants