-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Disable redirect slashes globally and remove trailing /
from /query
#328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyssadai
changed the title
Disable redirect slashes globally and remove trailing
[MNT] Disable redirect slashes globally and remove trailing Jul 29, 2024
/
from /query
/
from /query
alyssadai
changed the title
[MNT] Disable redirect slashes globally and remove trailing
[FIX] Disable redirect slashes globally and remove trailing Jul 29, 2024
/
from /query
/
from /query
alyssadai
added
the
pr-minor-breaking
Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0)
label
Jul 29, 2024
Pull Request Test Coverage Report for Build 10185692508Details
💛 - Coveralls |
rmanaem
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧑🍳
3 tasks
This was referenced Jul 30, 2024
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-minor-breaking
Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0)
release
Create a release when this PR is merged
released
This issue/pull request has been released.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
307
redirect which breaks reverse proxies via paths #327Changes proposed in this pull request:
/query
route no longer expects a slash at the end (or before query params)X-Forwarded...
proxy headers from all remote IPs, to ensure we don't losehttps
from a request once behind a proxy (this should happen less with the redirects now disabled, but this change should nonetheless act as a safeguard against different proxy server setups)Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: