[FIX] Remove attributes with a NULL label (#124)

* [FIX] Remove attributes with a NULL label * [CI] Add regression test for the null label attribute response * Update cypress/e2e/APIRequests.cy.ts Co-authored-by: Arman Jahanpour <[email protected]> --------- Co-authored-by: Arman Jahanpour <[email protected]>
neurobagel · Apr 12, 2024 · 439bc21 · 439bc21
1 parent e05c823
commit 439bc21
Show file tree

Hide file tree

Showing 3 changed files with 84 additions and 0 deletions.
diff --git a/cypress/e2e/APIRequests.cy.ts b/cypress/e2e/APIRequests.cy.ts
@@ -5,6 +5,7 @@ import {
   nodeOptions,
   diagnosisOptions,
   emptyDiagnosisOptions,
+  badDiagnosisOptions,
   partiallyFailedDiagnosisToolOptions,
   failedDiagnosisToolOptions,
   assessmentToolOptions,
@@ -200,6 +201,44 @@ describe('Successful API query requests', () => {
   });
 });
 
+// Bad things that should no longer happen
+describe('Regression Tests', () => {
+  it('App can start if attributes have null values and filters out bad attributes', () => {
+    cy.intercept(
+      {
+        method: 'GET',
+        url: '/nodes/',
+      },
+      nodeOptions
+    ).as('getNodes');
+
+    cy.intercept(
+      {
+        method: 'GET',
+        url: '/attributes/nb:Diagnosis',
+      },
+      badDiagnosisOptions
+    ).as('getDiagnosisOptions');
+
+    cy.intercept(
+      {
+        method: 'GET',
+        url: '/attributes/nb:Assessment',
+      },
+      assessmentToolOptions
+    ).as('getAssessmentToolOptions');
+
+    cy.visit('/');
+    cy.wait(['@getNodes', '@getDiagnosisOptions', '@getAssessmentToolOptions']);
+
+    cy.get('[data-cy="Diagnosis-categorical-field"]').type('parkin{downarrow}{enter}');
+    cy.get('[data-cy="Diagnosis-categorical-field"] input').should(
+      'have.value',
+      "Parkinson's disease"
+    );
+  });
+});
+
 describe('Partially successful API query requests', () => {
   beforeEach(() => {
     cy.intercept(

diff --git a/cypress/fixtures/mocked-responses.ts b/cypress/fixtures/mocked-responses.ts
@@ -169,6 +169,43 @@ export const failedDiagnosisToolOptions = {
   ],
 };
 
+// Real example of a bad response where some attributes
+// did not have labels in the federated nodes
+export const badDiagnosisOptions = {
+  errors: [
+    {
+      node_name: 'International Neuroimaging Data-sharing Initiative',
+      error:
+        'Bad Gateway: <html>\r\n<head><title>502 Bad Gateway</title></head>\r\n<body>\r\n<center><h1>502 Bad Gateway</h1></center>\r\n<hr><center>nginx/1.18.0 (Ubuntu)</center>\r\n</body>\r\n</html>\r\n',
+    },
+  ],
+  responses: {
+    'nb:Diagnosis': [
+      {
+        TermURL: 'snomed:49049000',
+        Label: "Parkinson's disease",
+      },
+      {
+        TermURL: 'snomed:77176002',
+        Label: null,
+      },
+      {
+        TermURL: 'snomed:197480006',
+        Label: 'Anxiety disorder',
+      },
+      {
+        TermURL: 'snomed:37796009',
+        Label: null,
+      },
+      {
+        TermURL: 'snomed:82838007',
+        Label: null,
+      },
+    ],
+  },
+  nodes_response_status: 'partial success',
+};
+
 export const assessmentToolOptions = {
   errors: [],
   responses: {

diff --git a/src/App.tsx b/src/App.tsx
@@ -76,6 +76,14 @@ function App() {
             enqueueSnackbar(`No ${dataElementURI.slice(3)} options were available`, {
               variant: 'info',
             });
+          } else if (response.data.responses[dataElementURI].some((item) => item.Label === null)) {
+            enqueueSnackbar(
+              `Warning: Missing labels were removed for ${dataElementURI.slice(3)} `,
+              { variant: 'warning' }
+            );
+            response.data.responses[dataElementURI] = response.data.responses[
+              dataElementURI
+            ].filter((item) => item.Label !== null);
           }
         }
         return response.data.responses[dataElementURI];