Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make authentication optional on UI #212

Closed
4 tasks done
rmanaem opened this issue Jul 15, 2024 · 1 comment · Fixed by #214
Closed
4 tasks done

Make authentication optional on UI #212

rmanaem opened this issue Jul 15, 2024 · 1 comment · Fixed by #214
Assignees
Labels
feat:improve Incremental, user facing improvements of an existing feature. released This issue/pull request has been released. type:feature Effort to deliver new features, feature changes & improvements

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Jul 15, 2024

Once neurobagel/api#322 is resolved, node API instances can also enable authentication.
We'd like the query tool to be able to work with both federation API and node API regardless of whether they have authentication enabled or not.
Although the authentication flow can be toggled on deployment, we want to make the authentication optional on the UI front to allow users to make queries to APIs that do not require authentication freely.
The goal here is to allow the user to send the query without having to authenticate, how APIs handle the presence or absence of the ID token when receiving and sending out requests and how they respond to requests is their responsibility.

  • User should be able to close the modal without authenticating
  • User should be able to access the modal again once it's closed
    • Preferably by selecting the profile menu
  • Requests should go out to the API whether user has been authenticated or not
@rmanaem rmanaem changed the title Make authentication optional Make authentication optional on UI Jul 15, 2024
@rmanaem rmanaem self-assigned this Jul 15, 2024
@rmanaem rmanaem added feat:improve Incremental, user facing improvements of an existing feature. type:feature Effort to deliver new features, feature changes & improvements labels Jul 16, 2024
@neurobagel-bot
Copy link

neurobagel-bot bot commented Aug 2, 2024

🚀 Issue was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat:improve Incremental, user facing improvements of an existing feature. released This issue/pull request has been released. type:feature Effort to deliver new features, feature changes & improvements
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

1 participant