Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Made authentication optional on the UI #214

Merged
merged 7 commits into from
Jul 17, 2024
Merged

[ENH] Made authentication optional on the UI #214

merged 7 commits into from
Jul 17, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Jul 16, 2024

Changes proposed in this pull request:

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit f3244a5
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/6697e9cea7cc850008ce9058
😎 Deploy Preview https://deploy-preview-214--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review July 17, 2024 12:39
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rmanaem, thanks for the PR!

left some comments, but 🧑‍🍳

cypress/component/AuthDialog.cy.tsx Outdated Show resolved Hide resolved
cypress/component/Navbar.cy.tsx Show resolved Hide resolved
src/App.tsx Show resolved Hide resolved
@rmanaem rmanaem merged commit 708adf5 into main Jul 17, 2024
9 checks passed
@rmanaem rmanaem deleted the feat-212 branch July 17, 2024 16:00
@neurobagel-bot
Copy link

neurobagel-bot bot commented Aug 2, 2024

🚀 PR was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make authentication optional on UI
2 participants