Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Added NB_QUERY_PATH env var to configure path variable #227

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Jul 26, 2024

Changes proposed in this pull request:

  • Added NB_QUERY_PATH env var to configure path variable

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Jul 26, 2024
Copy link

netlify bot commented Jul 26, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 425422f
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/66aa62b64646ae0008abfe02
😎 Deploy Preview https://deploy-preview-227--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review August 1, 2024 20:20
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @rmanaem!

I think we should find a more descriptive name for NB_QUERY_URL_PATH, especially for the internal variable name queryURLPath because when I see that in the codebase I am immediately thinking of a parameter I will include in a request to the f-API. I will open an issue for that, so we can discuss the name and then also update the recipes.

🧑‍🍳

@rmanaem rmanaem merged commit d73211c into main Aug 2, 2024
9 checks passed
@rmanaem rmanaem deleted the feat-226 branch August 2, 2024 14:32
Copy link

neurobagel-bot bot commented Aug 2, 2024

🚀 PR was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make app path configurable
2 participants