Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Adding CodeQL Configuration, File Change Limitation Script, Linting, Formatting, and Type-Checking #45

Closed
wants to merge 9 commits into from

Conversation

Sauradip07
Copy link
Contributor

@Sauradip07 Sauradip07 commented Mar 1, 2024

Changes proposed in this pull request:

  • ESLint Disable Check: This PR includes linting, formatting, and type-checking for TypeScript files.
  • Checking Workflow Files: It checks for unauthorized modifications to workflow files and specified project configuration files listed below:

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention fixes #27
  • Tests pass
  • Checks pass
  • Tests have been added

Checklist:

  • I have reviewed and tested the code changes in this PR.
  • I have ensured that the total number of file changes does not exceed 20.
  • I have checked for linting, formatting, and type-checking errors in TypeScript files.
  • I have confirmed that the changes align with project practices and guidelines.
  • I understand that any unauthorized modifications to workflow files or specified project configuration files will fail the PR.
    For new features:

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit 9725644
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65e23693636f8f0008e603e2
😎 Deploy Preview https://deploy-preview-45--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for neurobagel-query ready!

Name Link
🔨 Latest commit b9de49b
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-query/deploys/65f1b0b4c51f8100083a9412
😎 Deploy Preview https://deploy-preview-45--neurobagel-query.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Sauradip07 Sauradip07 mentioned this pull request Mar 2, 2024
2 tasks
@rmanaem
Copy link
Contributor

rmanaem commented Mar 4, 2024

@Sauradip07 Thanks for opening the PR. However, this issue is currently being worked on, so we'll review this PR once that work is completed.
In the meantime, please take a look at our guidelines for contributing.

@rmanaem rmanaem added the _community [BOT ONLY] PR label for community contributions. Used for tracking label Mar 4, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@rmanaem
Copy link
Contributor

rmanaem commented Mar 13, 2024

Thanks for contributing @Sauradip07 but we're going to close this PR as this issue has already been addressed.

@rmanaem rmanaem closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
_community [BOT ONLY] PR label for community contributions. Used for tracking
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Set up CIs
2 participants