-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Solution): Add NET8 support (In an addition to existing NET9) #122
base: main
Are you sure you want to change the base?
Conversation
In an addition to existing NET9
Not sure if it's will work without any problems: https://github.com/RainDance74/framework/blob/feature-dotnet-8/src/Neuroglia.Plugins/Services/NugetPackagePluginSource.cs#L160 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome, many thanks for your awesome work!
samples/CamelCaseTextTransformPlugin/CamelCaseTextTransformPlugin.csproj
Outdated
Show resolved
Hide resolved
For the tests, some are indeed unstable, but should be skipped. The others should pass as expected. I'll test locally to see what's what. On a side note, Blazor Dagre doesn't build anymore with those changes. |
Alright, gonna check it out |
Another side note, it might be easier if I just edit the culprit project, meaning the |
I dont see why not. AFAIK, it should pickup the currently running version of the framework, no? |
Yes, but in this case it will be necessary to have some specific version of AsyncAPI package required for NET8, or it will be updated somehow? |
It look like, just clarifying |
Indeed, there would be the need to create a specific version for it. Im aware it might not be optimal |
Fixed |
Well, as for other packages like Microsoft.Extensions.DependencyInjection, they use multiple target versions, just like here in the PR, also there might be a need to use #if statements for different versions of code. |
Seems there is an error in CI because no target framework installed, I guess I need some help on that because haven't really worked with github actions UPD: Fixed, but got a test failed, is it because they aren't stable? |
Didn't found a way to do it with the matrix. Used this approach: actions/setup-dotnet#240
9bed359
to
ee545fc
Compare
@RainDance74 Thank you for your awesome work! I'll have a look asap, but I'm presenting at FOSDEM this weekend and have a lot on my plate, so it might take a little while 😉 |
Alright, then you could merge it when you ready, closing WIP |
This pull request aims to support both currently supported by Microsoft .NET versions.
Tests on the main and current branches don't look stable to me, so I had about 7-11 tests failed locally (Win11).
Hope it will help to add support of .NET 8 for https://github.com/neuroglia-io/asyncapi.
If I did something wrong, please leave a comment, I will be happy to fix it if necessary.