-
Notifications
You must be signed in to change notification settings - Fork 58
WIP: Add FFX/RFX estimators #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tsalo: I'm now assuming |
Per a conversation with Camille Maumet, here, we don't scale the se or var maps by sample size. We just square the se maps to make the flameo-compatible var maps. All we should have to do is remove the line squaring the maps. |
Are we talking about standard error maps, or standard deviation maps? Standard errors are estimates of the SD of the population distribution underlying the observed sample. They depend on the sample size (because the estimate gets more precise the larger the sample). But if FSL expects variance maps, then yes, we just need to drop the sqrt. |
+1 on using "SE2" or "StdErr2" or somehow referencing `standard error'
terminology, as that is the only way to be clear about what is intended.
(AFAIK, all of the "var"s that @tsalo mentions are squared standard errors
-- aka varcopes -- and not population variances).
|
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 45.83% 45.71% -0.13%
==========================================
Files 68 68
Lines 4038 4047 +9
==========================================
- Hits 1851 1850 -1
- Misses 2187 2197 +10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 45.45% 45.45% +<.01%
==========================================
Files 70 70
Lines 4380 4448 +68
==========================================
+ Hits 1991 2022 +31
- Misses 2389 2426 +37
Continue to review full report at Codecov.
|
Still a WIP, but the |
I've generalized |
Now that PyMARE is up and running, and the PyMARE integration is mostly handled (minus Stan and MCC), should we close this? |
This PR adds new FFX and RFX estimators and restructures some of the estimation code. Main changes:
ffx
estimation function that runs a standard fixed-effects meta-analysis.method
argument to theFFX
class (renamed fromFFX_GLM
) that allows users to specify'fsl'
optionally (but defaults to the standard approach).ffx_glm
andmfx_glm
functions as they were just wrappers forfsl_glm
and we now have (or soon will have) alternative methods forFFX
andRFX
.TO DO:
stan_mfx
StanMFX
class that wrapsstan_mfx
and follows the existing APIstan_mfx
into separate compilation and estimation steps for efficiency