Merge pull request #574 from neutron-org/fix/empty-consensus-param

Fix: nil consensus param

app/upgrades/v4.0.0/upgrades.go

@@ -232,6 +232,11 @@ func enableVoteExtensions(ctx sdk.Context, consensusKeeper *consensuskeeper.Keep
 		return err
 	}
 
+	oldParams.Params.Version = &comettypes.VersionParams{App: 0}
+	if err := consensusKeeper.ParamsStore.Set(ctx, *oldParams.Params); err != nil {
+		return err
+	}
+
 	// we need to enable VoteExtensions for Slinky
 	oldParams.Params.Abci = &comettypes.ABCIParams{VoteExtensionsEnableHeight: ctx.BlockHeight() + 4}
 

app/upgrades/v4.0.0/upgrades_test.go

@@ -133,13 +133,6 @@ func (suite *UpgradeTestSuite) TestDynamicFeesUpgrade() {
 	ctx := suite.ChainA.GetContext()
 	t := suite.T()
 
-	oldParams, err := app.ConsensusParamsKeeper.Params(ctx, &types.QueryParamsRequest{})
-	suite.Require().NoError(err)
-	// it is automatically tracked in upgrade handler, we need to set it manually for tests
-	oldParams.Params.Version = &comettypes.VersionParams{App: 0}
-	// we need to properly set consensus params for tests or we get a panic
-	suite.Require().NoError(app.ConsensusParamsKeeper.ParamsStore.Set(ctx, *oldParams.Params))
-
 	upgrade := upgradetypes.Plan{
 		Name:   v400.UpgradeName,
 		Info:   "some text here",