Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor recent work #44

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Refactor recent work #44

merged 2 commits into from
Sep 13, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Sep 13, 2024

Clean up recent work and add time-resolved reduction.

The main issue os dealing with theta offset. Since it's not part of refred, but is part of the template.xml, it needs to be set to zero by default unless specified. This needs to be true for both reduction and time-resolved reduction.

  • The important code to review is in reduction.
  • The code in miniDAS is IS code that can be ignored.
  • The code in launcher is a small UI that can also be ignored.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 49.25373% with 34 lines in your changes missing coverage. Please review.

Project coverage is 82.36%. Comparing base (f7d3627) to head (02b4d6c).
Report is 17 commits behind head on next.

Files with missing lines Patch % Lines
reduction/lr_reduction/workflow.py 34.37% 21 Missing ⚠️
reduction/lr_reduction/time_resolved.py 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #44      +/-   ##
==========================================
+ Coverage   82.20%   82.36%   +0.15%     
==========================================
  Files          20       20              
  Lines        2327     2404      +77     
==========================================
+ Hits         1913     1980      +67     
- Misses        414      424      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet requested a review from backmari September 13, 2024 15:18
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

reduction/notebooks/workflow-fixed-tthd.ipynb Outdated Show resolved Hide resolved
@mdoucet mdoucet merged commit af8c3bb into next Sep 13, 2024
1 check passed
@mdoucet mdoucet deleted the update_tNR branch September 13, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants