Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dq for q summing #53

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Update dq for q summing #53

wants to merge 1 commit into from

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Dec 11, 2024

When summing in Q, the resolution should be computed differently. The geometric part is only related to pixel size.
This PR add this to the Q-summing option. It also cleans up the output files.

@mdoucet mdoucet requested a review from backmari December 11, 2024 17:50
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a small unit test for compute_resolution with q_summing? The code changes look fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants