Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class ReflectedBeamOptions #24

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Dec 11, 2024

Description of work:

The purpose of this dataclass is to store options that can be used to write the reflectivity file to QuickNXS format (already implemented) or ORSO format (to be implemented)

Check all that apply:

  • added release notes
    (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests

References:

  • Links to IBM EWM items: 8489

Manual test for the reviewer

Just make sure that pytest -n 1 tests/ succeeds on a local repository

Check list for the reviewer

  • release notes
    updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date

@jmborr jmborr self-assigned this Dec 11, 2024
Signed-off-by: Jose Borreguero <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (6c10df9) to head (e02c749).

Files with missing lines Patch % Lines
src/mr_reduction/reflectivity_output.py 98.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #24      +/-   ##
==========================================
+ Coverage   77.65%   77.90%   +0.25%     
==========================================
  Files          19       19              
  Lines        2278     2304      +26     
==========================================
+ Hits         1769     1795      +26     
  Misses        509      509              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr changed the title Class ReflectedBeamPptions Class ReflectedBeamOptions Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants