-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample Logs should store units, besides value #629
Comments
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
Signed-off-by: Jose Borreguero <[email protected]>
6 tasks
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
Signed-off-by: Jose Borreguero <[email protected]>
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
Signed-off-by: Jose Borreguero <[email protected]>
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
Signed-off-by: Jose Borreguero <[email protected]>
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
Signed-off-by: Jose Borreguero <[email protected]>
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
Signed-off-by: Jose Borreguero <[email protected]>
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
Signed-off-by: Jose Borreguero <[email protected]>
jmborr
added a commit
that referenced
this issue
Sep 7, 2020
…li-meters Signed-off-by: Jose Borreguero <[email protected]>
jmborr
added a commit
that referenced
this issue
Sep 8, 2020
Signed-off-by: Jose Borreguero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TODO:
NexusConvertingApp.split_sample_logs()
andHidraWorkspace.set_sample_log()
)HidraWorkspace.save_experimental_data()
)HidraProjectFile.read_sample_logs()
)Possible locations in the code base impacted by the introduction of
LogEntry
:Blocks #274
Notes in the current implementation of the sample logs:
SampleLogs Class
class SampleLogs
is instantiated inHidraWorkspace.__init__
as attribute_sample_logs
, with an empty stateHidraWorkspace._sample_logs
is initialized inHidraWorkspace._load_sample_logs(HidraProjectFile)
, whichcalls
HidraProjectFile.read_sample_logs()
Project File
The hierarchy of a HDF5 project file:
(Subruns begin at 1, not 0. )
Log entries contain a single float for each subrun number. The attribute is empty. The idea is to extend it to contain a value and a unit.
Writing the logs in a projectfile with
class HidraProjectFile
:HidraProjectFile._init_project()
creates datasets for logs and subruns, but don't fill themHidraProjectFile.append_experiment_log(log_name, log_value_array)
add one log entry in the logs datasetHidraProjectFile.write_sub_runs(sub_runs)
add data into the subruns datasetWriting the logs to a project file is done from a
HidraWorkspace
:HidraWorkspace.save_experimental_data()
callsHidraProjectFile.get_sample_log_values()
and immediately after callsHidraProjectFile.append_experiment_log()
The text was updated successfully, but these errors were encountered: