Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample Logs should store units, besides value #743

Merged
merged 8 commits into from
Sep 8, 2020
Merged

Sample Logs should store units, besides value #743

merged 8 commits into from
Sep 8, 2020

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Sep 7, 2020 •
edited
Loading

Work done:

  • added units attribute to sample logs
  • Hydraworkspace can transfer units to the sample logs
  • NeXusConvertingApp can transfer log units to SampleLogs
  • HydraWorkspace can save log units to the project file
  • HydraWorkspace can read log units from the project file
  • SampleLogs.get_pointlist creates point lists in units of mili-meters

Refs #629

@jmborr jmborr changed the title Refs #629 added units attribute to sample logs Sample Logs should store units, besides value Sep 7, 2020
@jmborr
Refs #629 Hydraworkspace can transfer units to the sample logs
a3de4fd 
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr
Refs #629 NeXusConvertingApp can transfer log units to SampleLogs
7adb9c4 
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr
Refs #629 HidraProjectFile can save units as attribute of the logs
a70aeea 
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr
Refs #629 HidraProjectFile can save units as attribute of the logs
af879f5 
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr
Refs #629 HidraWorkspace can save units to the project file
99224ee 
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr
Refs #629 HidraProjectFile can read units from the project file
df67c33 
Signed-off-by: Jose Borreguero <[email protected]>
@jmborr
Refs #629 SampleLogs.get_pointlist creates point lists in units of mi…
e651dcb 
…li-meters

Signed-off-by: Jose Borreguero <[email protected]>
peterfpeterson
peterfpeterson requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments

pyrs/core/nexus_conversion.py Show resolved Hide resolved
pyrs/core/nexus_conversion.py Show resolved Hide resolved
pyrs/dataobjects/sample_logs.py Show resolved Hide resolved
pyrs/dataobjects/sample_logs.py Show resolved Hide resolved
pyrs/projectfile/file_object.py Show resolved Hide resolved
tests/integration/test_reduction.py Show resolved Hide resolved
@peterfpeterson peterfpeterson merged commit 6f51a50 into next Sep 8, 2020
@peterfpeterson peterfpeterson deleted the 629_logs_units branch September 8, 2020 16:33
@peterfpeterson
Copy link
Member

Fixes #629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfpeterson peterfpeterson peterfpeterson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmborr @peterfpeterson