Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vtk error for qa #875

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix vtk error for qa #875

merged 1 commit into from
Sep 18, 2024

Conversation

fanchercm
Copy link
Collaborator

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@fanchercm fanchercm merged commit b86da68 into qa Sep 18, 2024
2 checks passed
@fanchercm fanchercm deleted the push_vtk_fix_qa branch September 18, 2024 18:24
@fanchercm fanchercm restored the push_vtk_fix_qa branch September 18, 2024 18:24
@fanchercm fanchercm deleted the push_vtk_fix_qa branch November 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant