Skip to content

Fix test warning #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 52 commits into from
Closed

Fix test warning #897

wants to merge 52 commits into from

Conversation

fanchercm
Copy link
Collaborator

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Fancher and others added 30 commits April 15, 2024 13:27
inital commit for excluding subruns
a6fe506
@fanchercm
added tracking to exclude points
3b1b3d7
@fanchercm
fix mypy errors
f67c37a
@fanchercm
Merge pull request #865 from neutrons/exclude_points
7e59356 
Exclude points
@fanchercm
fix calibration paramview
5913d25
@fanchercm
Merge pull request #866 from neutrons/fix_calibration_paramview
e9f281a 
fix calibration paramview
fix exclude
6fc9e0d
@fanchercm
Merge pull request #870 from neutrons/exclude_points_redevelop
0956506 
fix exclude
fix exclude
d2de327
@fanchercm
Merge pull request #871 from neutrons/exclude_points_redevelop
2f2da0d 
fix exclude
@fanchercm
changed how time averaged data are pulled
e62f6b9
@fanchercm
reset fit_results to catch error
2508df2
@fanchercm
Merge pull request #872 from neutrons/fix_time_averaged
8813531 
changed how time averaged data are pulled
@fanchercm
Merge pull request #873 from neutrons/fix_exclude_points
b865dc8 
reset fit_results to catch error
removed vtk from environment file
f6b5d79
removed vtk from conda.recipe
6a8a4d7
@fanchercm
remove vtk from meta.yaml run section
e4f3e38
@fanchercm
Merge pull request #874 from neutrons/test_remove_vtk
8cf0b41 
removed vtk from environment file
@fanchercm
added effective params to project file
d1c5f06
@fanchercm
disable export fitting when no file is loaded
38fc765
@fanchercm
Merge pull request #881 from neutrons/save_effective_params
c47162d 
added effective params to project file
@fanchercm
Merge pull request #882 from neutrons/fix_nopeakcollection_crash
62eb44b 
disable export fitting when no file is loaded
@fanchercm
added quadratic background
1ead534
@searscr @fanchercm
Enable UI tests (#877)
b277f1f 
* fix segfault in tests

* enable tests

* add comments

* fix formatting

* try-fix github actions

* fix texture fitting error

---------

Co-authored-by: Chris Fancher <[email protected]>
@fanchercm
inital commit allowing appended project files
6d3e9ff
@fanchercm
updated tests for additional effective param
35dce7f
@fanchercm
updated tests for additional effective param
01f481a
@fanchercm
changed the errors added to A2 variable when linear backgrounds are used
e342a90
@fanchercm
changed error array for non linear background
f11ec91
@fanchercm
added test for Quadratic background
f2ea722
fanchercm and others added 22 commits October 4, 2024 12:40
@fanchercm
fix flake8 error
52bcf3e
@fanchercm
Merge pull request #884 from neutrons/add_background_peakshape
c204bb4 
Add background peakshape
@fanchercm
inital commit for merge runs GUI
ef14105
@fanchercm
Merge pull request #885 from neutrons/multi_run_select
57a20ef 
Multi run select
@fanchercm
refactor of summary generator to speed up csv exports
0e4fcf2
@fanchercm
inital commit to fit multiple peaks browse option
c72f2b7
@fanchercm
allow multi run select from auto or manual reduction
14037d5
@fanchercm
increased the validation number
573a177
@fanchercm
changed validation int
78ad47e
@fanchercm
Merge remote-tracking branch 'origin/qa' into next
0b6b075
@fanchercm
Merge remote-tracking branch 'origin/main' into next
00aee4f
@fanchercm
inital commit of UI and backend testing
e3ef071
@fanchercm
allow selection of multiple files in peak fitting window
95a9b91
@fanchercm
fix flake8 error
34511ce
@fanchercm
Merge pull request #886 from neutrons/append_project_files
a0129d8 
Append project files
@fanchercm
added missing __init__.py in combined runs
11d0d19
@fanchercm
Merge pull request #888 from neutrons/fix_next_not_building
dff62b2 
added missing __init__.py in combined runs
fix np NaN error
5001f3a
@fanchercm
Merge pull request #890 from neutrons/next_fix
ab6b42a 
fix np NaN error
@fanchercm
Merge pull request #894 from neutrons/fix_numpy2_errors
9701877 
Fix numpy2 errors
@fanchercm
inital address test warnings
21d5b76
@fanchercm
refactor of reduction had a slight change to position and intensity v…
f649eec 
…alues
@fanchercm fanchercm closed this Dec 3, 2024
@fanchercm fanchercm deleted the fix_test_warning branch December 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanchercm @searscr