Ewm6534 fix missing parameters in call to raw vanadium correction algo#508
Merged
darshdinger merged 6 commits intonextfrom Nov 27, 2024
Conversation
…w-Vanadium-Correction-Algo
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #508 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 66 66
Lines 4959 4960 +1
=======================================
+ Hits 4788 4789 +1
Misses 171 171 ☔ View full report in Codecov by Sentry. |
dlcaballero16
approved these changes
Nov 27, 2024
Collaborator
dlcaballero16
left a comment
There was a problem hiding this comment.
Tested and runs as expected
rboston628
pushed a commit
that referenced
this pull request
Dec 6, 2024
#508) * Add all changes for testing on analysis. * Reverting changes for WorkflowImplementer. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Remove this, ended up in the wrong branch * Update diffcal_masking_script.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
This update addresses a defect in the Raw Vanadium Correction Algorithm within the SNAPRed application. The defect arose due to missing parameters
NumberOfSlicesandNumberOfAnnuliin calls to the Mantid algorithmsCylinderAbsorptionandSphericalAbsorption.These parameters were initially set to default values (
NumberOfSlices=1,NumberOfAnnuli=1), leading to potential inaccuracies in the absorption correction calculations. The default values are inadequate for the precise corrections required in vanadium normalization.By explicitly setting these parameters to
NumberOfSlices=10andNumberOfAnnuli=10, as in the original prototype, this fix ensures the corrected algorithms provide reliable results for vanadium data correction. These changes align the current implementation with the established prototype.Explanation of work
This PR was simple in execution.
The fix involves:
To test
Dev testing
Please insure all pytests pass first. Then, with a clear local state directory, take any run and perform both DiffCal and NormCal on the run and insure all features are functional (specifically within NormCal).
CIS testing
Not needed, but same as above.
Link to EWM item
EWM # 6534
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.