After completion of pixel calibration, show unfocused before and after #511
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Some users of SNAP want to see unfocused before/after workspaces, to help assess the usefulness of pixel calibration.
Explanation of work
One of the workspaces already existed, but was only retained in CIS mode.
Another of the workspaces is created at the end of
PixelDiffCalRecipe
.To test
Dev testing
Run calibration with 46680. It will fail, but not before creating the workspaces.
When it finishes, within the list of workspaces should be
dsp_046880_raw_beforeCrossCor
anddsp_046680_raw_afterCrossCor
. Check the following:Right click on the
tof_all_lite_raw_046680
workspace, and select to view the detectors. This will open a table workspace with the column DIFC.Then right click on "before" workspace and select the same. Verify the DIFC columns are identical between the original and the "before"
Right click on the "after" workspace and select the same. Verify the DIFC columns differ between the original and "after"
CIS testing
Run this with 58882 and Silicon (or your own choice).
Verify as above.
Also make sure, in slice viewer, that pixel calibration has done anything worthwhile.
Link to EWM item
EWM#7712
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.
NOTE this PR only applies to steps 1 and 2 described in the EWM item