Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After completion of pixel calibration, show unfocused before and after #511

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

rboston628
Copy link
Contributor

@rboston628 rboston628 commented Dec 3, 2024

Description of work

Some users of SNAP want to see unfocused before/after workspaces, to help assess the usefulness of pixel calibration.

Explanation of work

One of the workspaces already existed, but was only retained in CIS mode.

Another of the workspaces is created at the end of PixelDiffCalRecipe.

To test

Dev testing

Run calibration with 46680. It will fail, but not before creating the workspaces.

When it finishes, within the list of workspaces should be dsp_046880_raw_beforeCrossCor and dsp_046680_raw_afterCrossCor. Check the following:

  • both workspaces have 18432 spectra
  • both workspaces are in d-Spacing
  • both workspaces have the same binning
  • both workspaces can be viewed in sliceviewer by right clicking in the ADS

Right click on the tof_all_lite_raw_046680 workspace, and select to view the detectors. This will open a table workspace with the column DIFC.

Then right click on "before" workspace and select the same. Verify the DIFC columns are identical between the original and the "before"

Right click on the "after" workspace and select the same. Verify the DIFC columns differ between the original and "after"

CIS testing

Run this with 58882 and Silicon (or your own choice).

Verify as above.

Also make sure, in slice viewer, that pixel calibration has done anything worthwhile.

Link to EWM item

EWM#7712

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

NOTE this PR only applies to steps 1 and 2 described in the EWM item

  • After completion of pixel calibration and before group calibration, the user has access to before/after workspaces
  • The before/after workspaces are unfocused (18432 spectra in lite or 1.2M spectra in native)
  • The before/after workspaces functions of d-spacing
  • The before/after workspaces have the same binning
  • The before/after workspaces differ in that one has been converted to d-spacing using the input difcal convertion and the second has been converted using the difcal that include the offsets determined via the pixel calibration process
  • The user is then able to visually inspect both workspaces using mantid workbench slice viewer

@rboston628 rboston628 marked this pull request as ready for review December 3, 2024 20:51
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.55%. Comparing base (00a1099) to head (7b59e0b).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #511   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files          66       66           
  Lines        4960     4962    +2     
=======================================
+ Hits         4789     4791    +2     
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dlcaballero16 dlcaballero16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected

@rboston628 rboston628 merged commit 40daa45 into next Dec 4, 2024
8 checks passed
@rboston628 rboston628 deleted the ewm7712-before-after branch December 4, 2024 15:23
rboston628 added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants