Fix workflow presenter to run things from threads #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #514 +/- ##
==========================================
- Coverage 95.60% 95.56% -0.05%
==========================================
Files 66 66
Lines 4962 4962
==========================================
- Hits 4744 4742 -2
- Misses 218 220 +2 ☔ View full report in Codecov by Sentry. |
walshmm
reviewed
Dec 5, 2024
| continueOnSuccess = lambda success: self.advanceWorkflow() if success else None # noqa E731 | ||
| self.handleAction(verifyAndContinue, None, continueOnSuccess) | ||
|
|
||
| def handleAction(self, action, args, onSuccess): |
There was a problem hiding this comment.
Please add typehints, I think its important we know onSuccess is a Callable
walshmm
approved these changes
Dec 5, 2024
rboston628
added a commit
that referenced
this pull request
Dec 5, 2024
This reverts commit da4b224.
rboston628
added a commit
that referenced
this pull request
Dec 6, 2024
* fix workflow presenter to run things from threads * fix use of requests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add annotations to handleAction for callable --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
There are some processes which take place inside workflows. It is important these be able to return errors. Many of these methods were not sent to separate threads, which meant errors could not be handled through the universal error handling point.
This fixes that, providing a method for all workflows to call to easily send methods to new thread.
Explanation of work
Inside
WorkflowPresenter, split off the functionality that handles actions on continue to handle any kind of action.Updated the workflows to make use of this functionality, instead of their prior
try-catchblocks that only logged errors to the output.To test
Dev testing
This impacts the following parts of the UI:
Make sure these parts of the workflow are still completely correctly.
CIS testing
N/A
Link to EWM item
There is no ticket for this work , but it supports other work in
EWM#7712
Verification
N/A
Acceptance Criteria
N/A