Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated integration tests to work with ultralite data #516

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

dlcaballero16
Copy link
Collaborator

@dlcaballero16 dlcaballero16 commented Dec 6, 2024

Integration tests now use ultralite version of run 58882, set more fields in integration_test.yml to get tests to work, moved ultralite stuff into tests location

Description of work

Integration tests now use ultralite version of run 58882.

Explanation of work

Integration tests now use ultralite version of run 58882, fields are set in integration_test.yml to get tests to work, and I moved ultralite stuff into tests location so that the integration tests can easily reference the ultralite definition files.

To test

Dev testing

You will need to run the integration tests locally, since the test data repo will not have the ultralite data yet. On info on how to run the integration tests, check the Usage section in our readthedocs. The main thing here is to change the branch for the data repo. Switch the data repo to use branch switch-data-to-ultralite and then run the tests.

CIS testing

None

Link to EWM item

EWM#5760

Verification

  • the author has read the EWM story and acceptance critera
  • the reviewer has read the EWM story and acceptance criteria
  • the reviewer certifies the acceptance criteria below reflect the criteria in EWM

Acceptance Criteria

This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.

  • acceptance criterion 1
  • acceptance criterion 2

Integration tests now use ultralite version of run 58882,
set more fields in integration_test.yml to get tests to work,
moved ultralite stuff into tests location
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (195a469) to head (627337f).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #516   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files          68       68           
  Lines        5083     5083           
=======================================
  Hits         4858     4858           
  Misses        225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlcaballero16 dlcaballero16 marked this pull request as ready for review December 9, 2024 17:43
@darshdinger
Copy link
Contributor

Testing:


Screencast from 12-18-2024 02:02:38 PM.webm
All tests function as expected and pass!

@dlcaballero16 dlcaballero16 merged commit a7d0f20 into next Dec 19, 2024
8 checks passed
@dlcaballero16 dlcaballero16 deleted the update-integration-tests-with-ultralite branch December 19, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants