Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused test function #529

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Remove unused test function #529

merged 1 commit into from
Jan 15, 2025

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Jan 13, 2025

Everything has already moved to mantid.testing.assert_not_equal(). This is a maintenance task to remove the (now) unused function.

To test

This is a maintenance that has no functional difference in the code. The builds should pass and nothing else will be affected.

Link to EWM item

EWM#7338

Acceptance Criteria

workspacesNotEqual() should not appear anywhere in the snapred repository.

Everything has already moved to `mantid.texting.assert_not_equal()`
@peterfpeterson peterfpeterson force-pushed the ewm7338_wokspace_not_equal branch from 9e5fdbe to bce79d8 Compare January 13, 2025 16:44
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.76%. Comparing base (32de852) to head (bce79d8).
Report is 2 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #529   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files          68       68           
  Lines        5081     5081           
=======================================
  Hits         4866     4866           
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterfpeterson peterfpeterson marked this pull request as ready for review January 13, 2025 16:52
@walshmm walshmm merged commit 9c3f01d into next Jan 15, 2025
8 checks passed
@walshmm walshmm deleted the ewm7338_wokspace_not_equal branch January 15, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants