Skip to content

Minor issue that parameters are resolved as strings#133

Merged
AndreiSavici merged 3 commits intonextfrom
parameter_fixes
May 20, 2024
Merged

Minor issue that parameters are resolved as strings#133
AndreiSavici merged 3 commits intonextfrom
parameter_fixes

Conversation

@AndreiSavici
Copy link
Copy Markdown
Member

Short description of the changes:

Minor issue that parameters are resolved as strings

Long description of the changes:

getPropertyValue for False will return "0", which evaluates to True. Using getProperty("PropertyName").value returns a bool.
Similarly, the mask_btp_inputs is a string "[]" which evaluates to True

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@mpatrou mpatrou requested a review from a user May 20, 2024 18:07
@AndreiSavici AndreiSavici merged commit 89e5acc into next May 20, 2024
@AndreiSavici AndreiSavici deleted the parameter_fixes branch May 20, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants