Skip to content

Navigation toolbar added in figure#141

Closed
mpatrou wants to merge 1 commit intonextfrom
figure_tooltip_fix
Closed

Navigation toolbar added in figure#141
mpatrou wants to merge 1 commit intonextfrom
figure_tooltip_fix

Conversation

@mpatrou
Copy link
Copy Markdown
Collaborator

@mpatrou mpatrou commented Sep 23, 2024

Short description of the changes:

!! IN PROGRESS !!
There was an issue when Shiver was started through Mantidworkbench related to right plots in refine ub tab.

Long description of the changes:

The code defines (maintains a link of) NavigationToolbar. This resolves the Runtime Errors that would appear in console and Mantidworkbench, where users hover on the refine ub's (3 right) plots.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Defect 5317

@mpatrou mpatrou marked this pull request as draft September 24, 2024 13:34
@mpatrou mpatrou closed this Apr 3, 2025
@KyleQianliMa KyleQianliMa deleted the figure_tooltip_fix branch October 22, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant