Add magnetic structure factor correction #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
Ref: 8609: Add Magnetic structure factor correction to Shiver
The MagneticFormFactorCorrectionMD algorithm was only just added to mantid so you will need the mantid nightly version
>6.11.20241216.1838
for this to work. This also means a new version of matplotlib and move to numpy 2.0.I also fixed the codecov reporting which hasn't updated in 11 months so the diff is probably not accurate.
The "Magnetic structure factor" correction should now be enables.
You should be able to select which ion to use.
The workspace name should be appened with "_MSF"
If you plot them you can see the difference.
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References