Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move autoreducer to 3.1 in docker containers and add systemtest for new HIMEM autoreducer queue #159

Merged
merged 2 commits into from
Apr 19, 2024

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Apr 17, 2024

EWM4385

This adds a new docker container to the docker-compose that only processes HIMEM jobs.

A system test is written to have a task that send the reduction to the different queue and check that the correct container actually runs the task.

This also bumps the postprocessing version used to v3.1.0

This PR doesn't actually change any code for webmon itself, just test that it works correctly with the new postprocessing stuff

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@rosswhitfield rosswhitfield marked this pull request as ready for review April 17, 2024 06:04
@backmari
Copy link
Contributor

Looks good! Thanks for adding the system test.

@rosswhitfield rosswhitfield merged commit 2fb877c into next Apr 19, 2024
4 checks passed
@rosswhitfield rosswhitfield deleted the autoreducer_himem branch April 19, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants