Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust REF_M reduction configuration form layout #209

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

backmari
Copy link
Contributor

Description of the changes

The layout of the REF_M reduction configuration form is compressed to half the width of the page: https://monitor.sns.gov/reduction/ref_m/
Adjust the template style to make the form easier to read.

Before:

image

After:

image

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

Start up WebMon locally, navigate to http://localhost/reduction/ref_m/ and verify that the configuration form layout looks as in the "After" image above.

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (c91f6dd) to head (cc5792a).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #209      +/-   ##
==========================================
- Coverage   77.92%   77.88%   -0.05%     
==========================================
  Files          54       54              
  Lines        4734     4734              
==========================================
- Hits         3689     3687       -2     
- Misses       1045     1047       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari merged commit 5b7f266 into next Jan 17, 2025
4 checks passed
@backmari backmari deleted the ref_m_config_layout branch January 17, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants