Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Processing Agent v3.4.1 #213

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Post-Processing Agent v3.4.1 #213

merged 1 commit into from
Feb 19, 2025

Conversation

backmari
Copy link
Contributor

Description of the changes

Check all that apply:

  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • (If applicable) Verified that manual tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(Instructions for testing here)

Check list for the reviewer

  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (4dde35a) to head (e4549a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #213   +/-   ##
=======================================
  Coverage   77.86%   77.86%           
=======================================
  Files          54       54           
  Lines        4730     4730           
=======================================
  Hits         3683     3683           
  Misses       1047     1047           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -9,8 +9,8 @@ RUN dnf install -y procps-ng python3-numpy # pgrep is used for health check, num
RUN dnf install -y vim

# rpm needs to special groups first
RUN groupadd snswheel
RUN useradd snsdata -G snswheel
RUN getent group users || groupadd users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the extra protection of making sure the group doesn't already exist

Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the changes that actual installments do

@backmari backmari merged commit 24ccef2 into next Feb 19, 2025
4 checks passed
@backmari backmari deleted the post_processing_agent_v3.4.1 branch February 19, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants