Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of error when I(Q) fails assumption check #996

Merged
merged 40 commits into from
Feb 26, 2025

Conversation

glass-ships
Copy link
Member

@glass-ships glass-ships commented Feb 11, 2025

Description of work:

Check all that apply:

  • added release notes (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items: Story 9094
  • Links to related issues or pull requests:

Manual test for the reviewer

Check list for the reviewer

  • release notes updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Execution of tests requiring the /SNS and /HFIR filesystems

It is strongly encouraged that the reviewer runs the following tests in their local machine
because these tests are not run by the GitLab CI. It is assumed that the reviewer has the /SNS and /HFIR filesystems
remotely mounted in their machine.

cd /path/to/my/local/drtsans/repo/
git fetch origin merge-requests/<MERGE_REQUEST_NUMBER>/head:mr<MERGE_REQUEST_NUMBER>
git switch mr<MERGE_REQUEST_NUMBER>
conda activate <my_drtsans_dev_environment>
pytest -m mount_eqsans ./tests/unit/ ./tests/integration/

In the above code snippet, substitute <MERGE_REQUEST_NUMBER> for the actual merge request number. Also substitute
<my_drtsans_dev_environment> with the name of the conda environment you use for development. It is critical that
you have installed the repo in this conda environment in editable mode with pip install -e . or conda develop .

pre-commit-ci bot and others added 28 commits December 16, 2024 22:13
updates:
- [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.4.0...v5.0.0)
- https://github.com/charliermarsh/ruff-pre-commithttps://github.com/astral-sh/ruff-pre-commit
- [github.com/astral-sh/ruff-pre-commit: v0.0.275 → v0.8.3](astral-sh/ruff-pre-commit@v0.0.275...v0.8.3)
- [github.com/psf/black: 23.3.0 → 24.10.0](psf/black@23.3.0...24.10.0)
- [github.com/kynan/nbstripout: 0.6.1 → 0.8.1](kynan/nbstripout@0.6.1...0.8.1)
@glass-ships glass-ships changed the base branch from next to update-pre-commit February 11, 2025 16:41
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 78.26087% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.11%. Comparing base (e43aaec) to head (f5b3a10).
Report is 4 commits behind head on next.

Files with missing lines Patch % Lines
src/drtsans/iq.py 77.27% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #996      +/-   ##
==========================================
+ Coverage   86.07%   86.11%   +0.03%     
==========================================
  Files          97       97              
  Lines       10737    10767      +30     
==========================================
+ Hits         9242     9272      +30     
  Misses       1495     1495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from update-pre-commit to next February 11, 2025 17:32
@glass-ships glass-ships requested a review from jmborr February 19, 2025 19:29
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@glass-ships glass-ships merged commit df0cde3 into next Feb 26, 2025
2 checks passed
@glass-ships glass-ships deleted the check-iq-for-binning branch February 26, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants