Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ability to send key via query string #22

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Jul 8, 2024

Once WebMon (neutrons/data_workflow#169) and WebRef have been updated to use the new method of sending the secret key we can remove the old method.

Ref: 5923: [LiveDataServer] Change API key handling

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (7b2b256) to head (d74a0d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #22      +/-   ##
==========================================
- Coverage   86.87%   86.78%   -0.10%     
==========================================
  Files          10       10              
  Lines         282      280       -2     
==========================================
- Hits          245      243       -2     
  Misses         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant