-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep user data #37
Keep user data #37
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #37 +/- ##
==========================================
- Coverage 90.00% 89.85% -0.15%
==========================================
Files 10 11 +1
Lines 310 355 +45
==========================================
+ Hits 279 319 +40
- Misses 31 36 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch to not delete user data. The plots created in the unit tests are created correctly with the user data having an expiration date in 2100 and the instrument data three years into the future. Looks good to me 👌
livedatadb=# select * from plots_datarun;
id | run_number | run_id | created_on | instrument_id | expiration_date
----+------------+-------------------+-------------------------------+---------------+-------------------------------
5 | 12345 | | 2024-09-18 16:32:19.854356+00 | 5 | 2027-09-18 16:32:19.84804+00
6 | 6 | reflectivity.json | 2024-09-18 16:32:20.024337+00 | 6 | 2100-01-01 00:00:00+00
7 | 12346 | | 2024-09-18 16:32:20.51581+00 | 7 | 2027-09-18 16:32:20.512165+00
8 | 123 | | 2024-09-18 16:32:20.862616+00 | 8 | 2027-09-18 16:32:20.858818+00
(4 rows)
Short description of the changes:
This PR serves to modify the previously added code to preserve user-associated plots while only purging beamline data.
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References