Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REF_M and REF_L runs #13

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Add REF_M and REF_L runs #13

merged 5 commits into from
Nov 15, 2024

Conversation

backmari
Copy link
Contributor

@backmari backmari commented Nov 15, 2024

Description of the changes

  • Adding REF_L runs to be able to test a run status page locally when removing the fitting link to reflectivity.sns.gov.
  • Added documentation about adding the instrument as an "Active Instrument" in the WebMon database.

Check all that apply:

  • added release notes (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests

References:

Manual test for the reviewer

Check list for the reviewer

  • release notes updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.95%. Comparing base (6d92150) to head (7aead32).

Additional details and impacted files
@@           Coverage Diff           @@
##             next      #13   +/-   ##
=======================================
  Coverage   92.95%   92.95%           
=======================================
  Files           3        3           
  Lines         142      142           
=======================================
  Hits          132      132           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@backmari backmari merged commit cfb9366 into next Nov 15, 2024
1 check passed
@backmari backmari deleted the add_ref_m_runs branch November 15, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants