-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update definition.yml #1830
Merged
Merged
Update definition.yml #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entityBot
suggested changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beep boop bop.
I have found some errors processing these changes:
* Error PARSING domainType: 'ext-pdu' on dashboards for key 'kentik/panduit_pdu' - entitydefinitionemitter.repositories.github.FileNotFoundException: No file panduit-pdu-dashboard.json on repository folder ext-pdu
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT sum(timeSinceBufferBegin) / sum(timeSinceLastHeartbeat) - filter(sum(timeSincePaused), where actionName = 'CONTENT_RESUME' - filter(sum(timeSinceSeekBegin), where actionName = 'CONTENT_SEEK_END')) * 100 FROM VideoAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause cannot be used to produce a valid golden metric.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT sum(timeSinceAdBufferBegin) / sum(timeSinceLastAdHeartbeat) - filter(sum(timeSinceAdPaused), where actionName = 'AD_RESUME' - filter(sum(timeSinceAdSeekBegin), where actionName = 'AD_SEEK_END')) * 100 FROM VideoAdAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: The select clause cannot be used to produce a valid golden metric.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONENT_ERROR' and contentPlayhead = 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_START' and contentPlayhead=0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONENT_ERROR' and contentPlayhead = 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_START' and contentPlayhead=0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'CONENT_ERROR' and contentPlayhead = 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_START' and contentPlayhead=0) * 100' - Exception: The NRQL validator was not able to parse the selection.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead = 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_START' and adPlayhead = 0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead = 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_START' and adPlayhead = 0) * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'AD_ERROR' and adPlayhead = 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_START' and adPlayhead = 0) * 100' - Exception: The NRQL validator was not able to parse the selection.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONTENT_ERROR' and contentPlayhead > 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'CONTENT_ERROR' and contentPlayhead > 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'CONTENT_ERROR' and contentPlayhead > 0 / (FROM VideoAction SELECT count(*) WHERE actionName = 'CONENT_REQUEST') * 100' - Exception: The NRQL validator was not able to parse the selection.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead > 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - Exception: Error validating the query.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'SELECT count(*) WHERE actionName = 'AD_ERROR' and adPlayhead > 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_REQUEST') * 100 FROM VideoErrorAction WHERE entity.guid IN ('guid') FACET entity.name TIMESERIES' - analytics.nrql.parser.DiracParserException: Error at line 1 position 17, unexpected 'WHERE'
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Golden metrics for key 'count(*) WHERE actionName = 'AD_ERROR' and adPlayhead > 0 / (FROM VideoAdAction SELECT count(*) WHERE actionName = 'AD_REQUEST') * 100' - Exception: The NRQL validator was not able to parse the selection.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Summary metrics for key ''averageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'averageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'averageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'averageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.
* Error VALIDATING domainType: 'MEDIA_STREAMING-VIDEO' on Summary metrics for key ''adAverageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'adAverageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.' - Exception: 'adAverageBitrateMbps': wrong golden metric reference. Couldn't find a golden metric definition with key 'adAverageBitrateMbps', please populate 'goldenMetric' with a valid reference to an existing golden metric.
otaviocarvalho
approved these changes
Jan 15, 2025
otaviocarvalho
added a commit
that referenced
this pull request
Jan 16, 2025
This reverts commit ea58eaf.
@lindhorstdfca reverted it here, it is missing the linked dashboard and was blocking our pipeline. Please feel free to re-submit the PR for review. |
otaviocarvalho
added a commit
that referenced
this pull request
Jan 16, 2025
rohit-bandlamudi-nr
pushed a commit
to rohit-bandlamudi-nr/entity-definitions
that referenced
this pull request
Jan 17, 2025
Co-authored-by: Otávio Carvalho <[email protected]>
rohit-bandlamudi-nr
pushed a commit
to rohit-bandlamudi-nr/entity-definitions
that referenced
this pull request
Jan 17, 2025
This reverts commit ea58eaf.
bhansa-nr
pushed a commit
to bhansa-nr/entity-definitions
that referenced
this pull request
Jan 23, 2025
This reverts commit ea58eaf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant information
Added support for Panduit PDU's that are pulled in from Kentik
https://github.com/kentik/snmp-profiles/blob/main/profiles/kentik_snmp/panduit/panduit_pdu.yml
Checklist
identifier
will be unique and valid.